Ch4s3 / bandera / 3b4b54b174f81128cc26c824eb07847182602368-PR-13

93%

main: 93%

Pull #13

github

Fix FunWithFlags boolean gate migration

Prevents and fixes duplicate boolean gate rows that occur when migrating
from FunWithFlags to Bandera using an existing Ecto table.

Root cause: FunWithFlags stored boolean gates with a legacy target value;
Bandera uses "_bandera_none". The upsert conflict key is
(flag_name, gate_type, target), so the two sentinels don't conflict —
a second row is inserted rather than updating the first. The symptom is
a dashboard toggle that shows "on" while the summary shows "off", and
clicking the toggle appears to do nothing.

Changes:
- Add boolean-specific put/2 to the Ecto store that deletes any existing
  boolean row before inserting, preventing duplicates going forward
- Add Bandera.Ecto.Migrations.fix_fun_with_flags_boolean_gates/0, a
  migration helper for one-time cleanup of duplicates already in the DB
- Add mix bandera.gen.fix_fun_with_flags_migration to scaffold the
  migration file in one command
- Add a warning block to the migration guide Step 5 (Option A)

25 of 25 new or added lines in 3 files covered. (100.0%)

1043 of 1117 relevant lines covered (93.38%)

273.84 hits per line