Alan-Jowett / sonde / 26771948327

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(gateway): stamp `master_key_id`/`master_key_epoch` at INSERT time (#1115)

GW-2001 specified `init_master_key_id` as a first-startup backfill, but
nodes registered after startup had permanently NULL `master_key_id` in
the DB. Engine.rs line 1217 drops escrow fields from ACTUAL_STATE when
`master_key_id` is empty, so post-startup nodes never had escrow data
in the Azure actual-state table.

Root cause: all five INSERT paths (`upsert_node`, `insert_node_if_not_exists`,
`replace_state`, `store_phone_psk`, `replace_phone_psks`) omitted the
`master_key_id` and `master_key_epoch` columns.

Fix:
- Add `read_current_key_metadata()` helper that reads current key ID and
  epoch from `gateway_config`, failing closed if `init_master_key_id` has
  not been called (GW-2001 AC-6).
- Stamp all five INSERT paths with current key metadata.
- `upsert_node` ON CONFLICT also repairs stale/NULL metadata.
- Add shape validation (32-byte key ID, epoch >= 1).
- Add T-2005b integration test: node registered after init has escrow
  fields in ACTUAL_STATE.
- Update E2E harness to call `init_master_key_id` in constructors.

Spec changes:
- GW-2001 AC-6 (gateway-requirements.md)
- S23.6 INSERT-time stamping (gateway-design.md)
- T-2005b test case + traceability (gateway-validation.md)

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Coverage Stats

66 of 97 new or added lines in 2 files covered. (68.04%)

9 existing lines in 2 files now uncovered.

37943 of 46206 relevant lines covered (82.12%)

251.25 hits per line