Alan-Jowett / sonde / 26703053776

82%

push

github

feat(gateway): emit escrow fields on every node ACTUAL_STATE (GW-2005) (#1113)

* feat(gateway): emit escrow fields on every node ACTUAL_STATE (GW-2005)

Previously, node ACTUAL_STATE emissions from the WAKE path used
\mit_actual_state_for_node\ which hardcoded escrow fields to None.
Only the post-rotation path in \otation_engine\ populated escrow
data via \mit_actual_state_for_node_with_escrow\.

This change ensures every node ACTUAL_STATE emission includes the
PSK escrow fields (\ncrypted_psk\, \scrow_key_hint\,
\master_key_id\) when escrow data is available in storage.

Changes:
- Add \SqliteStorage::get_node_escrow_by_id()\ for single-node
  escrow lookup by primary key
- Remove \ConnectorEventHub::emit_actual_state_for_node()\ — all
  callers now use \mit_actual_state_for_node_with_escrow()\
- Update \handle_wake_core\ to query escrow data and populate
  escrow fields on every WAKE emission
- When escrow is unavailable (no sqlite_storage, NULL master_key_id,
  or lookup error), emit ACTUAL_STATE with null escrow fields and
  log a warning

Spec updates:
- GW-2005: amend description and add AC-4, AC-5
- Design §13A.3, §23.6: document per-WAKE escrow emission
- Validation: add T-2005a, update traceability matrix

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix: address PR review — dedupe allow attr, renumber steps, add T-2005a test

- Remove duplicate \#[allow(clippy::too_many_arguments)]\ on
  \mit_actual_state_for_node_with_escrow\
- Renumber WAKE handler steps: escrow emission is 4a, node_online
  event is 4b (corrects out-of-order numbering)
- Add \	est_t2005a_wake_actual_state_includes_escrow_fields\ — end-to-end
  test that sends a real WAKE through the gateway engine with
  \SqliteStorage\ and asserts ACTUAL_STATE keys 12/13/14

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

*... (continued)

63 of 70 new or added lines in 2 files covered. (90.0%)

37897 of 46125 relevant lines covered (82.16%)

251.45 hits per line