Logflare / logflare / 36e77e6f86a82b618615eec0a92b126283adcb25

81%

Build Type

push

github

Committed by web-flow

Commit Message

chore: gate BigQuery schema verification behind a config flag (default off) (#3543)

* chore: gate BigQuery schema verification behind a config flag (default off)

PR #3489 re-enabled on-ingest BigQuery schema type verification, which had
been a silent no-op for years (string-keyed body maps were merged against
the %SourceSchema{} struct's atom keys, so conflicts were never detected).
Because we don't yet know how the now-working verification behaves under
production traffic, disable it by default and re-enable in a later release
after more testing.

Gate the verification logic in BigQuerySchemaChange.validate/2 behind a
runtime Application env flag, defaulting off in config.exs. When off,
validate/2 returns :ok immediately, restoring the prior no-op behavior with
strictly less per-event work (no cache lookup, no typemap build/merge).

Using a runtime get_env (not a compile-time attribute) keeps check_body/4
and friends reachable, avoiding unused-function / unreachable-clause
warnings.

The validate/2 test block enables the flag in setup so the dormant-in-prod
logic stays fully covered; valid?/2 tests are unaffected. The per-source
validate_schema toggle is untouched and now sits below the global switch.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor: make BigQuerySchemaChange.enabled?/0 private

It is only called internally by validate/2, so drop it from the public
API surface per review feedback.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

12718 of 15763 relevant lines covered (80.68%)

3671.81 hits per line