stacklok / toolhive / 26763374418

66%

Build Type

push

github

Committed by web-flow

Commit Message

Isolate skills client discovery in default-client test (#5417)

TestNewDefaultClient stubbed the TOOLHIVE_API_URL env reader but let
the server-discovery step run against real local state. When a thv or
Desktop server was running, discovery found it and returned its base
URL, so the "falls back to default URL" and "applies options" subtests
saw the discovered URL instead of the default and failed. CI passed
only because no server is running there.

Inject the discovery step into newDefaultClientWithEnv, mirroring the
existing env.Reader injection, and have the subtests stub it. Each
resolution step (env var, discovery, default fallback) is now tested
in isolation, and a new subtest covers the discovered-server path.

Co-authored-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

2 of 3 new or added lines in 1 file covered. (66.67%)

14 existing lines in 4 files now uncovered.

65758 of 99792 relevant lines covered (65.9%)

64.22 hits per line