stacklok / toolhive / 26763112698

66%

Build Type

push

github

Committed by web-flow

Commit Message

Persist config backward-compat migrations to load path (#5416)

Loading a config from an explicit path (PathProvider, LoadOrCreate-
ConfigWithPath) that needed a backward-compatibility migration wrote
the migrated result to the default xdg path instead of the path it
was loaded from. applyBackwardCompatibility called the path-agnostic
save(), which always resolves to getConfigPath().

For tests this clobbered the developer's real config file whenever a
PathProvider loaded a temp config with a secrets provider set but
setup_completed false, defeating the isolation added for #894. It was
also a latent correctness bug for any path-based load in production.

Thread the load path through applyBackwardCompatibility and persist
via saveToPath(configPath). Remove the now-unused save() helper.

Closes #894

Co-authored-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

3 of 4 new or added lines in 1 file covered. (75.0%)

8 existing lines in 3 files now uncovered.

65753 of 99792 relevant lines covered (65.89%)

64.26 hits per line