Unleash / unleash / 26762836818

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add new prometheus integration metrics [auth/addons] (#12125)

## ❔ Why
As first phase of [deprecation of Google
Auth](https://linear.app/unleash/issue/EG-4389/remove-deprecated-google-auth-integration#comment-a2839212)
integration towards v8, we first need to know how many users are still
using it and decide if full deprecation is safe or to partially disable
it for now.

To collect this evidence, [we checked the
logs](https://platform.getunleash.io/grafana/explore?schemaVersion=1&panes=%7B%22m1h%22%3A%7B%22datasource%22%3A%224QZtDTP4z%22%2C%22queries%22%3A%5B%7B%22refId%22%3A%22A%22%2C%22expr%22%3A%22sum%28increase%28http_request_duration_milliseconds_count%7Bpath%3D%7E%5C%22.*%2Fauth%2F.*%2Flogin%5C%22%7D%29%29+by%28path%29%22%2C%22range%22%3Atrue%2C%22datasource%22%3A%7B%22type%22%3A%22prometheus%22%2C%22uid%22%3A%224QZtDTP4z%22%7D%2C%22editorMode%22%3A%22code%22%7D%5D%2C%22range%22%3A%7B%22from%22%3A%22now-30d%22%2C%22to%22%3A%22now%22%7D%7D%7D&orgId=1)
for the callback url `/auth/*/login` but there was is no register for
google login `/auth/google/login`.

Looked for generic /auth/*/login paths instead. When we exec:
```
sum by (path, method) (
  increase(http_request_duration_milliseconds_count{path=~"/auth/(oidc|saml|simple)/login|/auth/\\(hidden\\)"}[$__range])
)
```
we see many `/auth/(hidden)` paths. 
Grabbing only these ones:
```
sum(increase(http_request_duration_milliseconds_count{path="/auth/(hidden)"}[$__range])) by (status)
```
We don't get any `200`s . But we get: 80 `401`s, 2 `403`s and **4
`404`s.**

Most likely `/auth/google/*` is not mounted as a route. Looks like a
label normalization - the `prom-client` express middleware might record
route templates, not concrete URLs. The 4 × `404`s are users hitting
`/auth/google/login` and the server has no idea what to do with it.
_This_ missing bucket could be the count we're looking for.

We could make a fix to normalize the url properly but _still_ we won't
receive the old metrics... (continued)

Coverage Stats

1861 of 2056 branches covered (90.52%)

47 of 47 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

15169 of 17402 relevant lines covered (87.17%)

869.35 hits per line