zalando / skipper / 26751628948

80%

Build Type

push

github

Committed by web-flow

Commit Message

fix: wait for cipher refresher goroutine to exit on Close (#4036)

# Related Issue

Fixes a goroutine leak found while working on #4034.

## Problem

`Registry.Close()` called `v.Close()` on each encrypter but returned
immediately, leaving the `runCipherRefresher` goroutine running until it
observed the closed channel on its next select iteration. Under `noleak`
this caused a test failure in the `secrets` package.

## Fix

Initialize `closedHook` inside `runCipherRefresher` (only when a
goroutine is actually started) and drain it in `Registry.Close()` so
shutdown blocks until the goroutine has exited. The `nil` guard on the
drain ensures encrypters created without a refresh interval (no
goroutine started) are unaffected.

No behavior change in production - `Close()` is only called at shutdown.

---------

Signed-off-by: Larry D Almeida <hello@larrydalmeida.com>

Coverage Stats

5 of 5 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

28080 of 35022 relevant lines covered (80.18%)

80848.99 hits per line