kobotoolbox / kpi / 26743326613

82%

master: 76%

push

github

refactor(libraryAssetForm): change component to functional and use proper metadata DEV-2126 (#7072)

### 📣 Summary

Library asset create and edit forms now fully honor instance-configured
project metadata fields, and the select controls used in that form were
modernized and stabilized (new shared Select and MultiSelect wrappers,
Mantine input migration, shared theme base styles, and UI parity fixes).

### 📖 Description

Until now, the create/edit form for library templates and collections
rendered a fixed set of metadata fields (description, sector, country)
regardless of what the instance had configured. If an admin disabled one
of those, it still showed up; if they enabled `operational_purpose`,
`collects_pii`, or any custom extra metadata field, it was nowhere to be
found. The form now behaves the same way Project Settings already does
and renders exactly the fields the environment exposes.

### 💭 Notes

Changes here:

Core DEV-2126 behavior and TypeScript migration:
- LibraryAssetForm.tsx
- Replaced legacy class and mixin flow with a functional TypeScript
component.
- Metadata visibility is driven by environment config via
getProjectMetadataFieldsAsSimpleDict.
- Supports operational_purpose, collects_pii, and extra metadata fields.
- Uses shared ExtraProjectMetadataFields and keeps submit payload
metadata-complete to avoid silent clobbering.
  - Reflux listeners are centralized with explicit cleanup.
  - Migrated text inputs from TextBox to Mantine TextInput and Textarea.
  - Migrated select usage to shared Select and MultiSelect wrappers.
- jsapp/js/components/modalForms/extraProjectMetadataFields.js to
ExtraProjectMetadataFields.tsx
  - Ported to TypeScript with typed props and same functional behavior.
- jsapp/js/components/modalForms/libraryAssetForm.js removed.
- LibraryAssetForm.module.scss renamed from lowercase filename.
- projectSettings.js and bigModal.js
  - Import path updates for migrated and renamed files.

Select and MultiSelect fol... (continued)

8891 of 12051 branches covered (73.78%)

29175 of 35718 relevant lines covered (81.68%)

5.59 hits per line