• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

grpc / grpc-java / #20297
89%

Build:
DEFAULT BRANCH: master
Ran 01 Jun 2026 04:16AM UTC
Jobs 1
Files 658
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

01 Jun 2026 04:04AM UTC coverage: 88.886% (-0.002%) from 88.888%
#20297

push

github

web-flow
xds: Hold parsed service config in CdsUpdate

This avoids re-parsing the config within CdsLB, as the providers could
have changed and the config may no longer be valid.

Many usages of ServiceConfigUtil.unwrapLoadBalancingConfig() were
replaced with public API, which should be less brittle to internal
changes. Similarly, config.equals() was added for LBs least_request,
ring_hash, wrr to use more public APIs in testing. But I've gone out of
my way to avoid using equals for XdsClient change detection, by
preserving the original "JSON" config.

This fixes a bug in WRR config parsing which prevented it from parsing
errorUtilizationPenalty as it assumed it would be a Float, not a Double
like our parser actually generates and our API requires.
JsonUtil.getNumberAsFloat() was added specifically for WRR and has never
worked as JSON Numbers will always be Doubles.

In XdsClusterResource.CdsUpdate, the LB-specific fields like minRingSize
were already not used at all, so this commit deletes them as it seems a
relevant cleanup.

Fixes #12733

36493 of 41056 relevant lines covered (88.89%)

0.89 hits per line

Coverage Regressions

Lines Coverage ∆ File
25
83.23
-1.25% ../core/src/main/java/io/grpc/internal/JsonUtil.java
20
91.69
0.47% ../xds/src/main/java/io/grpc/xds/XdsClusterResource.java
18
93.46
0.52% ../xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java
5
75.0
-4.31% ../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
4
80.41
2.06% ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
4
85.25
-1.08% ../xds/src/main/java/io/grpc/xds/LeastRequestLoadBalancer.java
3
95.07
-0.44% ../core/src/main/java/io/grpc/internal/RetriableStream.java
1
90.91
0.35% ../core/src/main/java/io/grpc/internal/DelayedClientCall.java
1
87.88
-3.03% ../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
Jobs
ID Job ID Ran Files Coverage
1 #20297.1 01 Jun 2026 04:16AM UTC 658
88.89
Source Files on build #20297
  • Tree
  • List 658
  • Changed 13
  • Source Changed 0
  • Coverage Changed 13
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #20297
  • 3db3235e on github
  • Prev Build on master
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc