#20297
89%

Ran 01 Jun 2026 04:16AM UTC

Jobs 1

Files 658

Run time 1min

Badge

Embed ▾

Committed 01 Jun 2026 04:04AM UTC coverage: 88.886% (-0.002%) from 88.888%

Build # #20297

Build Type

push

github

Committed by

web-flow

Commit Message

xds: Hold parsed service config in CdsUpdate

This avoids re-parsing the config within CdsLB, as the providers could
have changed and the config may no longer be valid.

Many usages of ServiceConfigUtil.unwrapLoadBalancingConfig() were
replaced with public API, which should be less brittle to internal
changes. Similarly, config.equals() was added for LBs least_request,
ring_hash, wrr to use more public APIs in testing. But I've gone out of
my way to avoid using equals for XdsClient change detection, by
preserving the original "JSON" config.

This fixes a bug in WRR config parsing which prevented it from parsing
errorUtilizationPenalty as it assumed it would be a Float, not a Double
like our parser actually generates and our API requires.
JsonUtil.getNumberAsFloat() was added specifically for WRR and has never
worked as JSON Numbers will always be Doubles.

In XdsClusterResource.CdsUpdate, the LB-specific fields like minRingSize
were already not used at all, so this commit deletes them as it seems a
relevant cleanup.

Fixes #12733

Coverage Stats

36493 of 41056 relevant lines covered (88.89%)

0.89 hits per line

Coverage Regressions

Lines	Coverage	∆	File
25	83.23	-1.25%	../core/src/main/java/io/grpc/internal/JsonUtil.java
20	91.69	0.47%	../xds/src/main/java/io/grpc/xds/XdsClusterResource.java
18	93.46	0.52%	../xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java
5	75.0	-4.31%	../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
4	80.41	2.06%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
4	85.25	-1.08%	../xds/src/main/java/io/grpc/xds/LeastRequestLoadBalancer.java
3	95.07	-0.44%	../core/src/main/java/io/grpc/internal/RetriableStream.java
1	90.91	0.35%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
1	87.88	-3.03%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20297.1	01 Jun 2026 04:16AM UTC	658	88.89

grpc / grpc-java / #20297
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build #20297

grpc / grpc-java / #20297 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build #20297

grpc / grpc-java / #20297
89%

README BADGES
x