ruby-grape / grape / 26719391341

97%

master: 97%

Build Type

Pull #2751

github

Committed by ericproulx

Commit Message

Skip absent optional steps when composing structured error messages

`Grape::Exceptions::Base#compose_message` looped over every entry in
`MESSAGE_STEPS` (problem, summary, resolution) and translated each one
individually. For an optional step a message does not define — e.g.
`summary` on `invalid_message_body` — `Grape::Util::Translation#translate`
falls back to returning the scoped key path as a string. That string is
non-blank, so it passed the `detail.present?` guard and leaked verbatim:

    Summary:
      grape.errors.messages.invalid_message_body.summary

Gate each step on whether the already-resolved message hash defines it.
The resolved hash reflects the :en fallback, so locale fallback for
present steps is preserved, and the existing key-path behaviour for a
fully-unresolvable top-level message is untouched.

Fixes #2748.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2751: Skip absent optional steps when composing structured error messages

Coverage Stats

1105 of 1195 branches covered (92.47%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

3530 of 3590 relevant lines covered (98.33%)

23267.83 hits per line