stillwater-sc / universal / 26712742215

84%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

style: ASCII-only source/build files + warning cleanup (#1032)

* style: convert source and build files to ASCII-only, add CI guard

Replace all non-ASCII characters in source, CMake, and script files with
ASCII equivalents (box-drawing -> - | + =, math symbols -> ~= != <= >= -> <-
+/- sqrt inf, superscript/subscript runs -> ^2 / 10^-8 / x1, greek -> pi eps
delta, smart quotes/dashes -> ' " -- -). Also strip UTF-8 BOMs and a stray
Latin-1 0xBF byte (a mangled minus) in the long_double headers. Box-drawing
maps to single-width ASCII so tables stay aligned.

Documentation (*.md) and binary assets are out of scope.

Add tools/scripts/check-ascii.sh (byte-mode scan with LC_ALL=C to catch
invalid-UTF-8 bytes) and .github/workflows/ascii-guard.yml to enforce the rule
on PRs and pushes. Document the scope and equivalences in CLAUDE.md.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(internal): avoid GCC 13 -Warray-bounds false positive in renormalize_expansion

GCC 13 at -O2 inlines std::vector's copy constructor into the size<=1 fast path
of renormalize_expansion and, having proven the vector holds at most one
element, mis-reports the libstdc++ __builtin_memmove as forming an out-of-bounds
offset-8 pointer (a one-past-end pointer for an 8-byte copy). The copy is
correct; the diagnostic is a known false positive.

Split the early return into explicit empty / single-element constructions, which
is semantically identical but sidesteps the bounded copy-ctor path the analyzer
trips over. Verified the warning is gone with zero new warnings.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* style(ereal): split test increment onto its own line to fix -Wmisleading-indentation

The test idiom put two statements on one line:
    if (reportTestCases) std::cout << "    FAIL\n"; ++nrOfFailedTestCases;
The increment always runs (intended) but is not guarded by the if, and GCC's
-Wmisleading-indentation heuristic flags th... (continued)

Coverage Stats

44 of 47 new or added lines in 11 files covered. (93.62%)

3 existing lines in 1 file now uncovered.

46942 of 55860 relevant lines covered (84.04%)

6042851.56 hits per line