lsm / neokai / 26664489697

82%

Build Type

push

github

Committed by web-flow

Commit Message

Require Codex thumbs-up before review handoff (#2027)

* fix: require Codex reaction before review handoff

Enforce codex[bot] +1 on the QA review gate, add reviewer wait guidance, and keep live built-in gate script lookup effective for newly scripted gates.

* fix: harden Codex reaction polling

Use the larger reactions page, rely on Bun for timeout parsing, and align the fullstack reviewer short steps with the Codex wait requirement.

* feat: make Codex gate checks data-driven

* chore: format Codex gate feature panel

* fix: harden Codex gate feature evaluation

* test: update gate validation expectation

* fix: apply Codex review checks to reviewer workflows

* refactor: generalize gate feature handling

* fix: close Codex gate feature gaps

* fix: scope terminal gate checks to active path and add Codex guidance to Plan Review

- evaluateTerminalGateFeatures now accepts currentNodeId and only evaluates
  feature-backed gates on channels downstream from the current node. This
  prevents unrelated feature gates from blocking terminal actions.
- CODEX_REACTION_APPROVAL_GUIDANCE added to PD_PLAN_REVIEW_PROMPT so Plan
  Reviewers know to wait for codex[bot] before casting approval votes.

* fix: scope terminal checks, reject feature+script combos, wire gate validation into workflow writes

- evaluateTerminalGateFeatures now includes incoming gated channels (to) in
  addition to outgoing (from), so terminal actions from end nodes are still
  guarded by the gate that led to them.
- validateGate rejects gates that combine registered features with custom
  script or poll, preventing silent override of existing checks.
- SpaceWorkflowManager.createWorkflow/updateWorkflow now call validateGate()
  for every gate before persisting, catching misspelled/unregistered features
  and invalid combinations at write time.
- Tests added for all three behaviors plus built-in workflow gate validation.

* fix: inject PR URL into gate scripts, align Codex timeout, filter ... (continued)

Coverage Stats

9792 of 14268 branches covered (68.63%)

Branch coverage included in aggregate %.

499 of 653 new or added lines in 17 files covered. (76.42%)

23 existing lines in 3 files now uncovered.

82154 of 96232 relevant lines covered (85.37%)

297.09 hits per line