tari-project / tari / 26636618717

60%

Build Type

push

github

Committed by web-flow

Commit Message

feat(wallet): migrate legacy output key-ids to current format on startup (closes #7829) (#7859)

## Summary

Closes #7829.

On startup, the `OutputManagerService` now spawns a background task that
converts any `spending_key` / `script_private_key` column values stored
in the legacy `"managed.<branch>.<index>"` or `"imported.<pubkey>"`
format to the current `TariKeyId` encoding.

### Design choices

- **LIKE filter** - `WHERE spending_key LIKE 'managed.%' OR ... LIKE
'imported.%'` targets only rows that need migration. No full-table scan;
no BLOB columns loaded (only `id`, `spending_key`,
`script_private_key`).
- **No offset paging** - converted rows no longer match the filter, so
the batch always starts at offset 0 and the result set shrinks naturally
until empty.
- **Batch size 100** per iteration keeps each SQLite round-trip bounded.
- **Non-blocking** - launched via `tokio::spawn` before the service
event loop; wallet startup is not delayed.
- **No catch_unwind** - nothing in the migration path should panic;
errors for individual rows are logged and skipped.

### Files changed

| File | Change |
|------|--------|
| `storage/database/backend.rs` | Two new trait methods:
`fetch_outputs_with_legacy_key_ids` / `update_output_key_ids` |
| `storage/sqlite_db/output_sql.rs` |
`OutputSql::find_outputs_with_legacy_key_ids` (LIKE query, no BLOBs) +
`OutputSql::update_key_ids` |
| `storage/sqlite_db/mod.rs` | Trait impl on
`OutputManagerSqliteDatabase` |
| `storage/database/mod.rs` | Wrapper methods on
`OutputManagerDatabase<T>` |
| `service.rs` | `migrate_legacy_output_keys` free async fn +
`tokio::spawn` call in `start()` |
| `tests/.../storage.rs` | `test_migrate_legacy_output_key_ids` -
injects `"managed.comms.0"`, verifies LIKE filter detects it, verifies
conversion to `TariKeyId::SpendKey`, verifies row is cleared from
filter, verifies clean outputs are unaffected |

### Test

```
cargo test -p minotari_wallet test_migrate_legacy_output_key_ids
```

Pas... (continued)

Coverage Stats

0 of 137 new or added lines in 4 files covered. (0.0%)

11 existing lines in 6 files now uncovered.

71894 of 117306 relevant lines covered (61.29%)

222830.42 hits per line