tari-project / tari / 26628635933

60%

Build Type

push

github

Committed by web-flow

Commit Message

fix(common): make StaticApplicationInfo work for crates.io consumers (#7860)

## Summary

TL;DR for Humans: the StaticApplicationInfo assumes you're in a git
repo, which isnt the case on crates.io, meaning compilation fails. This
PR handles this by reading the version filled in by crates.io in the
CARGO_MANIFEST_DIR Cargo.toml

Fixes `tari_common`'s `StaticApplicationInfo` build helper so that
crates depending on tari/minotari **via crates.io** (rather than as
in-tree workspace members or git pins) actually get a usable
`APP_VERSION_NUMBER`. Today the helper returns `""` for registry
consumers, which downstream gets baked into `consts::APP_VERSION_NUMBER`
and causes `minotari_node` to panic at startup parsing `""` as semver.

This unblocks moving downstream consumers (e.g. tari-ootle) off git pins
onto published crates.io versions.

## Why it's broken on crates.io today

`StaticApplicationInfo::initialize()` calls `find_git_root()`, which
walks up from `CARGO_MANIFEST_DIR` looking for a `.git` directory, then
reads the `Cargo.toml` at that location and pulls the version from
`[workspace.package].version`.

When the helper runs from
`~/.cargo/registry/src/index.crates.io-XXX/<crate>-X.Y.Z/`:

1. **No `.git` anywhere up the registry source tree.** The walk had a
hardcoded 10-iteration cap on `..` joins (not on real ancestors),
bailed, and returned `CARGO_MANIFEST_DIR` — the unpacked crate's own
dir.
2. **The crate's own `Cargo.toml` is the published one.** Cargo strips
workspace inheritance on publish and substitutes literals into
`[package].version`, so `[workspace.package]` doesn't exist in the
published manifest.
3. The helper only read `[workspace.package].version`, so it returned
`""`.
4. That empty string ended up as `consts::APP_VERSION_NUMBER`, and
`minotari_node/src/bootstrap.rs` does
`APP_VERSION_NUMBER.parse::<Version>().expect("Unable to parse
application version. Not valid semver")` → panic on startup.

## Fix

In `common/src/build/applicat... (continued)

Coverage Stats

53 of 70 new or added lines in 1 file covered. (75.71%)

121 existing lines in 15 files now uncovered.

71797 of 117169 relevant lines covered (61.28%)

223003.53 hits per line