MushroomObserver / mushroom-observer / 26634103303

97%

main: 97%

push

github

species_lists_controller: trim under 250 lines; drop ClassLength disable

After #4390 (`SpeciesList#sync_projects`) and #4391 (`Location.dubious_reasons_for`) trimmed the controller, the `# rubocop:disable Metrics/ClassLength` directive needed only one small additional pass to come off cleanly. Three changes.

1. **Drop the `skip_bullet` around-action** (12 lines: 8 of stale comment + 2 of `around_action` + the `only:` array). The block protected `:create` / `:update` from a Bullet warning about eager-loading `synonyms` for `@deprecated_names` in `edit_species_list`. But `@deprecated_names` is set only by `SpeciesLists::WriteInController` (via `init_name_vars_from_sorter` in `SharedPrivateMethods`), not by the main controller — the comment described a code path that no longer exists here. All 37 controller tests + 3 Capybara integration tests pass without the skip. If Bullet ever surfaces a real warning in CI, we add a targeted skip back.

2. **Collapse `case params[:flow]` in `#show`** from a 6-line case-statement (two `when` branches doing the same thing with different symbols) to a 3-line conditional that picks the symbol off the param value directly.

3. **Simplify `#validate_place_name`** by letting `Location.dubious_reasons_for` handle the `approved:` gate (the "user already confirmed this name" case) and collapsing the rest of the gate (`if location_id.nil?`) to a one-line early return. The species_list-specific "unknown / blank place name → set Unknown location" mutation block stays — that's not something the helper can express. 9 lines off the method. Behavior preserved across all four input cases (`unknown/blank` / `location_id` set / `approved == place_name` / `approved != place_name`) — existing `test_create_with_dubious_place_name_renders_warning` and `test_create_with_unknown_place_redirects_to_new_location` exercise the two corner cases the helper now handles.

`Metrics/ClassLength` reads 247 (was 258 with the disable suppressing it).

... (continued)

4 of 4 new or added lines in 1 file covered. (100.0%)

39512 of 40942 relevant lines covered (96.51%)

669.49 hits per line