dangernoodle-io / breadboard / 26616776982

100%

push

github

fix(bb_mdns): relocate txt[] pointers after batch flush memcpy (#316)

commit #311 fixed the analogous aliasing in batch_append_locked but missed
the flush path (batch_do_flush_locked). the memcpy in that path copies each
entry's payload[] into the queue item but leaves txt[].key/value aimed at
the source s_batch buffer. s_batch is a persistent static that the next
browse burst overwrites before the single-core-starved dispatcher drains the
item, so the dispatcher reads another peer's txt — producing cross-attributed
worker/version fields and blank entries in the knot peer table.

fix inserts a pointer-relocation loop (mirroring the append path) between the
memcpy and the s_batch.count = 0 reset. validated on esp32-c3: peer workers
then matched hostnames with zero missing version fields.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1334 of 1334 branches covered (100.0%)

Branch coverage included in aggregate %.

2268 of 2268 relevant lines covered (100.0%)

912.72 hits per line