agama-project / agama / 26586921140

81%

push

github

Try boot partitions with desired and min sizes (#3559)

## Problem

The logic to calculate boot-related partitions in yast2-storage-ng
defines three sizes for each partition: min, desired and max.

When using that in Agama, desired is ignored and only min and max are
taken into account. That's something we always wanted to re-evaluate
(together with several other aspects related to proposing boot
partitions).

When installing with enough available space (let's say in an empty disk
or allowing the installer to delete partitions) then there is often no
practical difference. The distance between min, desired and max is so
small in comparison with the rest of partitions to create that any
attempt (starting with either min or desired) always produces the same
result. See #3394 for the whole rationale.

But the result is non-optimal when resizing existing partitions just as
much as needed to make space for the new installation. In those case
Agama is creating partitions with min sizes that where intended for
extreme cases, not really as the best practice.

## Solution

This introduces a new approach in which several different sets of
boot-related partitions are calculated and tried. In this case, it makes
a first attempt using the desired sizes as starting point and, if that
fails, a second attempt using the min size as starting point.

This results in more reasonable proposal in most cases, without
introducing the risk of failing in edge cases that used to work when
using the min sizes.

## Testing

- Added a new unit tests

## Note

This is a "resurrection" of #3394, which was archived for the wrong
reasons.

4360 of 6388 branches covered (68.25%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 2 files covered. (100.0%)

23744 of 28133 relevant lines covered (84.4%)

95.29 hits per line