wol-soft / php-json-schema-model-generator / 26578946039

99%

master: 99%

push

github

Fix duplicate builder methods when two properties share a $ref (#130)

PropertyProxy's fluent setters returned the wrapped inner property
instead of $this, so a chain like `(clone $proxy)->setReadOnly(false)->...`
silently escaped to the underlying Property. The BuilderClassPostProcessor
relies on chain identity to mutate each property's clone, so two schema
properties pointing at the same $ref collapsed onto the first one's
underlying Property — emitting duplicate getter/setter pairs under the
first property's name and producing a fatal "Cannot redeclare" error.

Every fluent setter on PropertyProxy now mutates the inner property and
returns $this. This also corrects four other call sites that had the same
latent bug (composition merge, transferred properties, additional
properties accessor, schema dependencies).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

10 of 24 new or added lines in 1 file covered. (41.67%)

5921 of 5989 relevant lines covered (98.86%)

586.49 hits per line