agama-project / agama / 26564326053

81%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): unify authentication forms and complete SSH Public Keys support (#3531)

## Summary

What began as adding SSH public key support to the first-user workflow
evolved into a broader a
uthentication form refactor. Supporting SSH keys cleanly required
migrating both authentication forms to TanStack Form first, and once
that work was underway, consolidating the flows into a single page
became the most coherent UX direction.

The result is a unified authentication experience that reduces
navigation overhead, improves consistency, and simplifies both
validation and configuration handling.


## What Changed

### Unified authentication form (`authentication-form/`)

The previous `FirstUserForm`, `RootUserForm`, and `UsersPage` flows
(including their routes) have been consolidated into a single
`AuthenticationForm` page.

Both user sections are now visible and editable in one place,
eliminating unnecessary navigation and making related authentication
settings easier to manage together.

### SSH public key support for the first user

The first-user section now supports SSH public keys through an
`ArrayField` implementation with several SSH-specific improvements:

- Newline-aware paste handling via `splitPasteOn=/\r?\n/`, allowing
multi-line key blocks to paste correctly
- Middle truncation of long key entries through `maxEntryWidth=60` for
improved readability
- SSH key validation that rejects malformed entries and private keys

### `ArrayField` enhancements

`ArrayField` was extended to support more flexible entry handling and
better usability:

- Added `splitPasteOn` prop to customize paste splitting behavior
  - Defaults to whitespace/comma splitting
- Supports newline-only splitting for values that legitimately contain
spaces, such as SSH public keys
- Added `maxEntryWidth` prop to truncate long entries using PatternFly’s
`Truncate` component while preserving full values in accessibility
labels
- Added defensive null checks around `value` handl... (continued)

Coverage Stats

4351 of 6379 branches covered (68.21%)

Branch coverage included in aggregate %.

285 of 296 new or added lines in 17 files covered. (96.28%)

28 existing lines in 13 files now uncovered.

23721 of 28110 relevant lines covered (84.39%)

94.87 hits per line