MushroomObserver / mushroom-observer / 26544194847

97%

push

github

ApplicationForm field helpers: accept String name for non-bound fields + sweep callers (#4382)

* ApplicationForm field helpers: accept String field_name for non-bound fields

Generalize the pattern `hidden_field` has carried alone: every
`*_field` helper now accepts either a Symbol (model-bound; field
reads/writes through the form's model / FormObject) or a String
(raw HTML `name` attribute; value carried via the `value:` option).
This lets non-bound fields — operation state under nested namespaces
like `member[lat]`, `list[members]`, `member[notes][Cap]` — go
through the same helpers as model attributes, instead of forcing
callers into `Components::ApplicationForm::FieldProxy.new(...)` +
`render(Components::ApplicationForm::TextField.new(proxy, ...))`
boilerplate at every site.

Pattern in callers, before:

    proxy = Components::ApplicationForm::FieldProxy.new(
      "member", :specimen, "1"
    )
    render(Components::ApplicationForm::CheckboxField.new(
      proxy, checked: @member_specimen, label: ...
    ))

After:

    checkbox_field("member[specimen]", value: "1",
                                       checked: @member_specimen,
                                       label: ...)

## How it works

`FieldProxy` already mirrored most of `Superform::Rails::Field`'s
shape (`.dom.{id,name}`, `.value`, `.key`, `.parent`). It was
missing the factory methods (`.text`, `.textarea`, `.checkbox`,
`.select`, `.radio`, `.autocompleter`, `.date`, `.file`,
`.read_only`, `.static`) that `Field` overrides to build the
Bootstrap-styled MO field components. The fix:

- Extract those factory methods into `FieldFactoryMethods` (one
  module, single source). Both `Field` and `FieldProxy` include it.
  `AUTOCOMPLETER_OPTIONS` moves to the module alongside the
  autocompleter method that uses it.
- Each `*_field` helper grows one line: `f = resolve_field(name,
  value:)` — Symbol → `field(name)`, String → `FieldProxy.new(nil,
  name, value)`. Downstream `.text/.tex... (continued)

79 of 79 new or added lines in 11 files covered. (100.0%)

39111 of 40551 relevant lines covered (96.45%)

665.19 hits per line