MushroomObserver / mushroom-observer / 26524359265

97%

push

github

Inline project_alias link helpers into Widget; delete ProjectsHelper (#4381)

* Inline project_alias link helpers into Aliases::Widget; delete ProjectsHelper

The two remaining methods on \`ProjectsHelper\` — \`edit_project_alias_link\`
and \`new_project_alias_link\` — each had a single caller
(\`Views::Controllers::Projects::Aliases::Widget\`, which registered them
as output helpers). Inlined as private \`render_edit_link\` and
\`render_new_link\` methods on Widget, using Phlex's emit style.

With those gone, \`app/helpers/projects_helper.rb\` is empty — deleted.
The misnamed-pair tab builders \`edit_project_alias_tab\` /
\`new_project_alias_tab\` already moved to \`Tabs::ProjectsHelper\` in
#4378, so Widget reaches them via the \`Tabs::*Helper\` auto-include
established in #4376.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Phlex conversion docs: scope is ERB + its helpers, every time

Add a top-of-document section establishing that the helper-side
cleanup is part of every Phlex conversion PR — not a follow-up,
not a "later" thing. ERB-era helpers exist to work around ERB
being a bad place to write Ruby; once the view is Phlex they
stop earning their keep and should be inlined unless they
genuinely cross helper modules.

Codifies a rule the user has now flagged enough times that it
belongs in writing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

39102 of 40542 relevant lines covered (96.45%)

668.11 hits per line