orneryd / NornicDB / 26514003497

87%

Build Type

push

github

Committed by orneryd

Commit Message

fix(storage): rebuild node label index from bodies on engine open (#183)

  Stores carried over from older binaries — or reconstructed via file-level
  copy of a Badger directory mid-write — can have node bodies present and
  the corresponding prefixLabelIndex (0x03) keys absent. labels(n) and
  property-based selection still resolve correctly because they read the
  node's authoritative Labels slice; only MATCH (n:Label), which goes
  through the index, silently returns 0 rows for every pre-existing node
  after restart. Closed by a marker-gated, non-blocking startup backfill
  that mirrors the edge-between rebuild from #125: drop the prefix-0x03
  range, walk every node body in 50k-write Badger txn chunks, re-emit
  (label, nodeNumID) entries, then write prefixMVCCMetaLabelIndexReady so
  subsequent opens skip the work. Cancelled cleanly on Close.

  Pinned with badger_label_index_backfill_test.go (7 tests) covering the
  canonical repro, multi-label nodes, empty-store fast path, idempotency
  across restarts, cancel-on-close, stale-entry eviction, and namespaced
  reads. label_index_restart_test.go (8 tests) pins the live write path's
  persistence contract end-to-end.

Coverage Stats

140 of 182 new or added lines in 3 files covered. (76.92%)

27 existing lines in 8 files now uncovered.

130823 of 153686 relevant lines covered (85.12%)

0.99 hits per line