stillwater-sc / universal / 26488972496
84%
master: 84%

LAST BUILD BRANCH: feat/issue-931-7.6-elreal-forward-trig-v2
DEFAULT BRANCH: master
Ran
Jobs 1
Files 661
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.982% (-0.03%) from 84.011%
26488972496

push

github

web-flow 
fix(qd): correct qd_pi_3 constant (was pi/2) and make the constants test enforce (#914) (#1014)

qd_pi_3 in qd_constants.hpp carried the value of pi/2 (leading component
1.570796326794896558) with only 2 components instead of 4 -- a partial/abandoned
edit. Replaced with the correct 4-component quad-double expansion of pi/3
(1.0471975511965979, ...), generated with MPFR/mpmath; the leading component and
trailing residuals are consistent with how the other constants in the file were
produced (verified my extraction reproduces qd_pi/qd_pi_2/qd_pi_4 exactly).

qd_pi_3 has no call sites in the qd implementation (only the constants header and
this test), so the wrong value was a latent constant-table error with no
functional impact beyond the constant itself.

The constants test (static/highprecision/qd/api/constants.cpp) was why this
slipped through: it printed each constant vs its reference but never asserted,
and `main` returned EXIT_SUCCESS unconditionally ("ignore failures"). Now:
- add qd_pi3 to the reference table,
- assert every table constant matches its reference within a generous tolerance
  (1e-50; the max observed error across all constants is ~8e-65, so this catches
  gross errors like a wrong leading component while tolerating last-ULP drift),
- assert the algebraic invariant 3*qd_pi_3 == qd_pi,
- honor nrOfFailedTestCases in the return.

Verified: passes gcc+clang with the fix; injecting the old pi/2 value makes the
test exit non-zero (it now catches the bug).

Resolves #914

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

46858 of 55795 relevant lines covered (83.98%)

5786662.41 hits per line

Coverage Regressions

Lines Coverage ∆ File
10
31.43
 -3.57% include/sw/universal/verification/test_suite_randoms.hpp
8
93.64
 -0.47% include/sw/universal/number/cfloat/cfloat_impl.hpp
Jobs
ID Job ID Ran Files Coverage
1 26488972496.1 661
83.98
 GitHub Action Run
Source Files on build 26488972496