prisma-risk / tsoracle / 26486441515

95%

Build Type

push

github

Committed by web-flow

Commit Message

test(standalone): eliminate close/rebind port-bind race in openraft_membership tests (#530)

* test(standalone): eliminate close/rebind port-bind race in openraft_membership tests

The lease_port → drop(lease) → build(addr) pattern leaves a window between
the listener drop and the consumer's own TcpListener::bind(addr) inside
build_openraft. Under parallel-test load the kernel can re-issue the
freshly-freed ephemeral port to another bind(:0), causing AdminBind /
PeerBind { AddrInUse } panics. Observed today as the only failing test in
PR #519's coverage job (admin_grpc_list_and_add_learner at
openraft_membership.rs:198, AddrInUse on 127.0.0.1:43429, while PR #519
itself touches only docs).

The narrow-the-window mitigation (keep the listener alive until just
before the consumer binds) is what we already had — but the consumer's
bind is many ms downstream (RocksDB open, raft init, then peer/admin
bind), so the window stayed large enough to flake.

Close the window mathematically: thread the pre-bound TcpListener
through build, so the test never drops it. PortLease::into_listener
hands the held socket directly to a new test-only build path:

  build_openraft_with_listeners(cfg, raft_listener, admin_listener)
    → build_openraft_inner(cfg, Some(raft), admin)
  build_openraft(cfg)
    → build_openraft_inner(cfg, None, None)  // unchanged production

Production code (no listener supplied) binds inline at the same call
sites as before — preserving error precedence and the existing
PeerBind/AdminBind failure paths exercised by build_in_process.rs's
bind-conflict tests.

The test-only entry point is gated on `cfg(any(test, feature =
"test-support"))`, matching the existing seam pattern in
admin/mod.rs::test_support. tests/openraft_membership.rs is gated on
the same feature and gets a [[test]] required-features entry so cargo
prints a visible skip notice when the feature is not enabled — mirrors
the existing activation_admin_rpc test target.

Refactors serve_... (continued)

Coverage Stats

55 of 55 new or added lines in 3 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

13547 of 14263 relevant lines covered (94.98%)

340870.24 hits per line