orneryd / NornicDB / 26455168367
87%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 474
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.059% (-0.06%) from 85.123%
26455168367

push

github

orneryd 
fix(cypher,storage): resolve mcp-neo4j-memory regressions; full Lucene wildcard parity

  The mcp-neo4j-memory tool surfaced four independently reproducible
  defects against v1.1.0. All four are fixed here with deeply-asserted
  regression tests; Neo4j 5.x DDL and Lucene wildcard semantics are
  preserved end-to-end.

  Bug 1 — map-param property access stored as literal text
  The WITH-binding substitution treated `m.<key>` as a standalone
  identifier and replaced just `m`, producing `{name:'hello'}.name`
  literal text in the downstream clause. New expandMapMemberAccess
  runs first for map-typed bindings, expanding `<ident>.<key>` into
  the property's Cypher literal value. Token boundary checks (word /
  underscore / dot) keep unrelated identifiers untouched. Fixes
  WITH $entity AS entity MERGE (e:Memory {name: entity.name}) and
  the UNWIND-WHERE shape that mcp's create_entities depends on.

  Bug 2 — fulltext index ignored declared label scope; no wildcard
  queryNodes had no wildcard handler so '*' silently produced 0 rows
  through the BM25 term path; queryRelationships had no type-scope
  filter at all and accepted every edge. Three Lucene wildcard
  shapes are now first-class on both procedures: '*' (MatchAllDocs),
  '*:*' (Solr-style equivalent), and '<prop>:*' (field-presence).
  Each shape honors the index's declared scope (Labels for nodes,
  RelationshipTypes for edges), property allowlist, and returns
  empty for undeclared fields — matching Neo4j-Lucene posting-list
  semantics. The schema gained a RelationshipTypes []string field
  with `omitempty` JSON tag so old binaries reading new files see
  no extra key (forward compat) and new binaries reading old files
  see an empty slice (backward compat); no on-disk schema-version
  bump. AddFulltextRelationshipIndex helper plus parser support for
  the Neo4j 5.x form `CREATE FULLTEXT INDEX … FOR ()-[r:Type]-()`
  round out the surface.

  Bug 3 — WHERE / WITH-WHERE after CALL…YIELD ret... (continued)

305 of 459 new or added lines in 9 files covered. (66.45%)

52 existing lines in 11 files now uncovered.

130569 of 153504 relevant lines covered (85.06%)

0.99 hits per line

Uncovered Changes

Lines Coverage ∆ File
94
78.01
 -1.6% pkg/cypher/clauses.go
16
90.0
 0.47% pkg/cypher/match_with.go
13
93.58
 -1.88% pkg/cypher/call_compat.go
13
88.32
 -4.23% pkg/cypher/call_fulltext.go
7
70.59
 0.23% pkg/cypher/executor_subqueries.go
5
85.84
 -0.16% pkg/storage/schema.go
4
78.06
 -0.05% pkg/cypher/schema.go
2
79.84
 0.1% pkg/cypher/call.go

Coverage Regressions

Lines Coverage ∆ File
28
83.96
 -2.58% pkg/server/server.go
4
88.32
 -4.23% pkg/cypher/call_fulltext.go
3
93.58
 -1.88% pkg/cypher/call_compat.go
3
88.7
 -1.26% pkg/knowledgepolicy/binding_builder.go
3
95.58
 -1.2% pkg/storage/property_key_dictionary.go
3
90.07
 -0.99% pkg/temporal/decay_integration.go
2
90.79
 -0.66% pkg/cypher/optimized_executors.go
2
78.06
 -0.05% pkg/cypher/schema.go
2
89.27
 0.34% pkg/nornicdb/db_admin.go
1
78.01
 -1.6% pkg/cypher/clauses.go
1
97.64
 -0.26% pkg/temporal/tracker.go
Jobs
ID Job ID Ran Files Coverage
1 26455168367.1 474
85.06
 GitHub Action Run
Source Files on build 26455168367