wboayue / rust-ibapi / 26435063853

92%

Build Type

push

github

Committed by web-flow

Commit Message

accounts: decode_managed_accounts proto-only at floor 213 (PR-C3) (#636)

* accounts: decode_managed_accounts proto-only at floor 213 (PR-C3)

Gate is PROTOBUF_REST_MESSAGES_3 (213), the connection floor since #632.
Flip decode_managed_accounts wrapper to require_proto() over
&ResponseMessage; sync/async fixtures migrate from
managed_accounts().accounts(...).encode_pipe() text frames to
proto_response(IncomingMessages::ManagedAccounts, ...encode_proto()).
One-shot callsites wrap the decoder in a closure since
one_shot_with_retry processor signature is still Fn(&mut ResponseMessage).

Delete test_managed_accounts_scenarios (async) +
test_managed_accounts_additional_scenarios (sync) + ManagedAccountsTestCase
+ managed_accounts_test_cases(): the happy-path edge cases
(single-account, trailing-comma, multi-account, empty) are already covered
by the existing decode_managed_accounts_proto* unit tests in
decoders/tests.rs over the same wire format. New
test_decode_managed_accounts_rejects_text_framing locks in the proto-only
contract.

* test_utils: extract create_test_client_with_ordered_proto_responses helper

PR-C1/C2/C3 each repeated the same 4-line block to build a proto-fixture
test client: Arc::new(MessageBusStub::with_ordered_responses(vec![...]))
+ Client::stubbed(message_bus.clone(), server_versions::SIZE_RULES). PR-C3
adds five such blocks (3 sync + 2 async on managed_accounts alone). This
is the rule-of-three trigger called out in plans/floor-213-ratchet.md
§"/simplify follow-ups".

Extract the pair (async + sync siblings) alongside the existing text-only
create_test_client_with_responses helpers; fold the five new PR-C3
callsites onto it. Pre-existing manual setups in other tests stay
untouched (separate consistency-sweep PR per the plan).

* plans: mark create_test_client_with_ordered_proto_responses shipped in C3

Coverage Stats

16 of 16 new or added lines in 4 files covered. (100.0%)

5 existing lines in 3 files now uncovered.

19534 of 21160 relevant lines covered (92.32%)

26.88 hits per line