dangernoodle-io / TaipanMiner / 26429539489

90%

push

github

refactor(pool_stats): replace magnitude ceilings with NaN/inf + schema sentinel (#427)

- legitimate counters grow without bound (a bitaxe at 1.4 TH/s accumulates
  ~4e19 hashes/year, far above any finite ceiling); magnitude-based validators
  for shares, hashes, blocks, and best_diff were fundamentally wrong for
  monotonic counters and would silently wipe real data
- validators now flag only genuine corruption signatures: NaN/inf on best_diff
  (via integer bit-test, avoiding GCC FP instrumentation branch artifacts),
  out-of-range timestamps, and cross-field invariants
- schema-version sentinel (BB_POOL_STATS_SCHEMA_VERSION 1) written to NVS key
  "ps_schema" on every save; read before loading any slot or lifetime data on
  init — mismatch wipes all ps_* keys and resets the in-memory table, catching
  stale-layout reads after firmware upgrades that change the on-disk format
- explicit-key wipe list in pool_stats_wipe_keys() avoids touching non-pool_stats
  keys in the shared "taipanminer" NVS namespace
- host test injection hooks (inject_schema, inject_slot, inject_lifetime_blocks,
  get_saved_schema) simulate NVS persistence for schema-sentinel and load-path
  coverage without requiring real NVS partition
- 100% line and branch coverage for mining_pool_stats.c (94 / 94 branches)

2559 of 3227 branches covered (79.3%)

Branch coverage included in aggregate %.

93 of 93 new or added lines in 1 file covered. (100.0%)

5186 of 5360 relevant lines covered (96.75%)

154068.47 hits per line