wboayue / rust-ibapi / 26421037358

92%

Build Type

push

github

Committed by web-flow

Commit Message

connection: raise protobuf floor 210 → 213 (#632)

* connection: raise protobuf floor 210 → 213

Multi-gate ratchet 210 → 213 (PROTOBUF_REST_MESSAGES_3, skipping 211 +
212). Per plans/floor-213-ratchet.md the bump is mechanical: every
incoming response gated at 211/212/213 is either ⚪ not implemented in
the crate, ⚠️ dual-format (decode_proto_or_text), or ✅ already
proto-only. The display_groups orphan proto decoder was wired through
decode_proto_or_text in #631 — the one blocker.

Bumps:
- ConnectionHandler::default min_version + require_protobuf_support
- Test-fixture SERVER_VERSION constants in connection/client tests
- PROTOBUF_HISTORICAL_DATA → PROTOBUF_REST_MESSAGES_3 in 30+ historical
  and realtime fixture sites (decorative; bumping for hygiene)
- 17 hardcoded "v210..221" handshake mock strings in
  transport/sync/tests.rs
- Renamed test_require_protobuf_support_rejects_previous_place_order_floor
  to _rejects_previous_scan_data_floor, reflecting the new previous-floor
  (210)

Live IB Gateway reports server_version 220, well above 213 — no user
lockout risk.

* /simplify: sweep missed PROTOBUF_SCAN_DATA holdouts + revert version-pinned comments

Found by /simplify review:

- 6 scanner test-fixture sites in scanner/{sync,async}_tests.rs
- 4 _rejects_text_framing tests (contracts, scanner, orders) that derived
  their server_version from the floor
- proto_response() helper default in src/common/test_utils.rs (affects
  every proto-fixture call site, including PR-A's new test)
- Doc-comment refs in contracts/news/orders/scanner decoder modules:
  drop the inline (PROTOBUF_SCAN_DATA = 210) parenthetical so the comment
  doesn't rot at every future bump; keep the family-gate references
  where the gate is a load-bearing fact (e.g. scanner_data at 210)
- docs/migration-3.0.md SLONG note: revert 'well below our floor of 213'
  to 'well below our floor' (comment is about a server-35 gate; floor
  number was decorative)

* plan: mark PR-A shipped (#63... (continued)

Coverage Stats

5 of 5 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

19584 of 21244 relevant lines covered (92.19%)

27.61 hits per line