kobotoolbox / kpi / 26401549835

81%

master: 76%

push

github

refactor(libraryAssetForm): migrate to TypeScript DEV-2126 (#7069)

### 💭 Notes

Changes here:

- **`jsapp/js/components/modalForms/LibraryAssetForm.tsx`** (was
`libraryAssetForm.js`)
- Migrated the class component to TypeScript and renamed the file to
PascalCase (also the sibling `LibraryAssetForm.module.scss`).
- Added typed props (`AssetResponse`, `AssetTypeName`,
`WithRouterProps`) and a typed `FormFields` / `LibraryAssetFormState`.
- Dropped the `assetUtils` default-import in favor of the named
`removeInvalidChars` (only thing used here).
  - All comments preserved.
- **`jsapp/js/components/modalForms/ExtraProjectMetadataFields.tsx`**
(was `extraProjectMetadataFields.js`)
- Migrated to TypeScript with typed props for both the inner
`ExtraProjectMetadataField` and the default-exported
`ExtraProjectMetadataFields`.
- `onChange` now has a proper signature — `LibraryAssetForm` no longer
needs an `any`-style cast to talk to it.
- **`jsapp/js/components/bigModal/bigModal.js`** +
**`jsapp/js/components/modalForms/projectSettings.js`**
  - Updated import paths to the renamed files.

This is 2nd part of preparation for actual DEV-2126 fix.

### 👀 Preview steps

1. ℹ️ have an account
2. open **Library** → click **NEW** → **Collection**
3. fill in name + a couple of fields → **Create**
4. 🟢 the collection is created and you land on its page (same as before)
5. open the same collection → click the **Modify details** in top right
corner
6. tweak name/description/sector/country → **Save**
7. 🟢 changes persist and the modal closes
8. repeat 2–7 picking **Template** instead of **Collection** (template
lands on the editor after create)
9. open **Projects** → **NEW** → **Build from scratch**, fill in the
project settings form and save
10. 🟢 extra metadata fields render and submit identically to before

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: magicznyleszek <2521888+magicznyleszek@users.noreply.github.com>

9238 of 12471 branches covered (74.08%)

30549 of 37241 relevant lines covered (82.03%)

5.73 hits per line