KarpelesLab / goro / 26390930020

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower expr-context $x = ($obj->prop = v) natively via OP_OBJECT_SET B=1

Currently expr-context object property assignment falls through to
OpClassConst (generic AST.Run delegation) because OP_OBJECT_SET pops
both receiver and value with no push. Add a B-flag that pushes the
value back after the set, matching PHP's assignment-expression
semantics where ($obj->prop = v) evaluates to v.

emitObjectVarAssign no longer rejects expr context; it emits
OP_OBJECT_SET with B=1 for expr-context, B=0 for stmt-context. The
emitAssign branch in emit_expr.go drops the e.stmtCtx restriction
on the objectVarNode LHS branch.

Slot safety unchanged: OP_OBJECT_SET's handler doesn't touch caller
locals, so bodies with plain '=' on static-name non-nullsafe object
properties stay slot-safe in expr context too.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

19 of 19 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

14772 of 118475 relevant lines covered (12.47%)

2580.44 hits per line