KarpelesLab / goro / 26390819898

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower unset($obj->prop) natively via OP_UNSET_OBJ_PROP

Currently unset($obj->prop) falls through to OpTryFinally (generic
AST stmt delegation). Add a native opcode that pops the receiver and
reads the prop name from the const pool, then dispatches to
EvalUnsetObjProp.

EvalUnsetObjProp mirrors runObjectVar.WriteValue's value==nil top-
level branch — non-ZObjectAccess receivers silently ignore (PHP 8
unset-on-null behavior), object receivers dispatch to
objI.ObjectSet(name, nil) which the downstream ZObject handles as
unset (including __unset magic and visibility checks).

IsUnsetSupportedArg extended to accept objectVarNode shapes with
static names (non-dollar-prefix, non-nullsafe). Nested chains
($a->b->c) still AST-delegate — the AST's unsetChain marker on
intermediate runObjectVar nodes isn't reproduced here.

UnsetAllSupported now returns true for bodies that mix
$x / $x[$k] / $obj->prop unsets, keeping them slot-safe and
fully native-emitted.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

27 of 44 new or added lines in 4 files covered. (61.36%)

31 existing lines in 5 files now uncovered.

14764 of 118468 relevant lines covered (12.46%)

2580.57 hits per line