jacob-meacham / rotary-voip / 26386918502

59%

push

github

fix(dial): add dial-start settle window to catch off-normal close glitch

The level-poll alone leaves a small race at dial-start: GPIO22 takes
a few µs to settle LOW once the user starts pulling the dial, and
if a contact-close glitch fires on GPIO27 during those µs, the level
check sees LOW (transition already happened by the time we poll) and
the glitch gets counted as a real pulse.

Add an explicit settle window: subscribe to DIAL_ACTIVE FALLING
edges; when one arrives after a long quiet period (= genuine
dial-start, not mid-pulse-train chatter), open a 50 ms window during
which pulses are dropped. Real digit pulses only start hitting GPIO27
once the user actually releases the dial (hundreds of ms after the
off-normal closed), so the settle window doesn't eat any real pulses.

The mid-pulse-train DIAL_ACTIVE LOW edges (the off-normal contact
chattering along with the pulse contact, internal-jumper artifact on
this dial) are filtered by the quiet-period requirement, so they
don't reset the settle window mid-digit.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

24 of 28 new or added lines in 1 file covered. (85.71%)

2414 of 4062 relevant lines covered (59.43%)

0.59 hits per line