jacob-meacham / rotary-voip / 26386056412

59%

push

github

fix(dial): poll DIAL_ACTIVE level instead of tracking its edges

Earlier attempts to use GPIO22 (off-normal) as a digit-boundary signal
ran aground because on this dial the off-normal switch chatters along
with the pulse contact (internal jumper between blue and white).
Trying to track its edges led to spurious "dial started" events
mid-pulse-train.

Much simpler: just poll DIAL_ACTIVE's level each time a pulse fires
on DIAL_PULSE. If it reads HIGH (dial at rest), the pulse is noise —
EMI from hook switch operation, contact glitch with no actual dial
movement, etc. — and we drop it. The fact that GPIO22 chatters HIGH
briefly between pulses doesn't matter, because no real pulse fires
on GPIO27 during those brief HIGH gaps; only real pulses (when
GPIO22 is reliably LOW) reach the level check.

Removes the edge subscription on DIAL_ACTIVE and all the settle /
quiet-period / dial-start tracking. Keeps inter-pulse timeout for
emission.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

3 of 5 new or added lines in 1 file covered. (60.0%)

2391 of 4035 relevant lines covered (59.26%)

0.59 hits per line