prisma-risk / tsoracle / 26372462050

95%

push

github

refactor(server): drop BuildError::InvalidLeaderHintKey runtime check (#100) (#313)

LEADER_HINT_TRAILER_KEY is a const &'static str, so the validate_key()
call in ServerBuilder::build could only fail on a developer error that a
passing build already rules out. The check duplicated what the
validate_key_accepts_real_key unit test proves on every build, while
pulling a runtime error variant (InvalidLeaderHintKey) onto the public
BuildError surface for a condition that cannot occur in practice.

Remove the variant, the validate_key() function, and the build-time call
site. The unit test remains as the real guard, now asserting the const
parses as a BinaryMetadataKey directly. with_leader_hint's doc is
reworded to drop the stale validate_key reference.

2 of 2 new or added lines in 1 file covered. (100.0%)

11252 of 11856 relevant lines covered (94.91%)

486782.42 hits per line