prisma-risk / tsoracle / 26368912159

95%

push

github

fix(client): distinguish fanned-out transport failures from NoReachableEndpoints (#241) (#300)

* fix(client): distinguish fanned-out transport failures from NoReachableEndpoints (#241)

`clone_client_error` fans one RPC failure out to every sibling waiter in a
coalesced request chunk. Because `tonic::transport::Error` is not `Clone`, a
single endpoint's `Transport` failure was reconstructed as
`NoReachableEndpoints` — a distinct meaning ("the whole cluster is
unreachable"). Tracing and alerting on the receiving side drew the wrong
conclusion for every sibling waiter in the batch.

Add a `ClientError::TransportFanout(String)` variant carrying the original
error's `Display` text. The value itself still cannot be duplicated, but the
failure stays semantically a single-endpoint transport failure, distinct from
`NoReachableEndpoints`.

- `clone_client_error` maps `Transport(e)` -> `TransportFanout(e.to_string())`,
  and re-clones an already-fanned-out `TransportFanout` faithfully (the
  multi-chunk fail-fast path in `run_chunks` clones the stored error again for
  each subsequent chunk).
- `is_transport_failure` groups `TransportFanout` with `Transport` (same
  transport-failure semantics), keeping the single source of truth shared by
  `should_backoff` and channel eviction honest.
- The two benchmark `is_transient` copies are updated identically.

`ClientError` is a pre-1.0 `pub` enum without `#[non_exhaustive]`, so adding a
variant is a breaking change for exhaustive downstream matchers.

* test(client): recognize TransportFanout in TLS integration assertions (#241)

The coalescing driver applies `clone_client_error` to every waiter — even a
lone one — so a `get_ts()` whose RPC fails with `Transport` now reaches the
caller as `TransportFanout`, never the raw `Transport`. Two TLS integration
assertions and the tls-mtls example matched only `Transport(_)` after a
`get_ts()` and so broke (these are runtime matches the workspace build cannot
catch; only `ca... (continued)

19 of 21 new or added lines in 3 files covered. (90.48%)

11113 of 11718 relevant lines covered (94.84%)

514045.81 hits per line