prisma-risk / tsoracle / 26368837491

95%

push

github

refactor(core): extract projected_grant; try_grant writes back only on success (#250) (#301)

try_grant advanced next_physical_ms/next_logical before the PhysicalMsOutOfRange and WindowExhausted checks, so a failed grant left allocator state advanced — safe today (advances are forward-only) but surprising and untested on the advance->fail->extend->retry path. would_grant separately re-implemented the same advance simulation, kept in sync only by a prose doc comment.

Extract a pure associated fn project_grant(next_physical_ms, next_logical, committed_high_water, now_ms, count) -> Result<(physical_ms, logical_start), CoreError> owning the wall-clock advance, logical-wrap advance, and both bounds checks. try_grant now calls it and writes state back only on success; would_grant delegates via .is_ok(). Result (not Option) preserves the PhysicalMsOutOfRange vs WindowExhausted distinction try_grant's callers require.

Adds a regression test asserting a failed try_grant does not pin next_physical_ms to the failed attempt's wall clock.

60 of 60 new or added lines in 1 file covered. (100.0%)

11099 of 11703 relevant lines covered (94.84%)

495489.24 hits per line