c-ares / c-ares / 26365495514

92%

push

github

Defer TCP connection error handling until DNS responses are parsed (#1138)

This PR fixes a TCP read/disconnect ordering flaw in c-ares where valid
DNS responses can be dropped if a peer disconnects immediately after
sending data.

Connection error handling is deferred:
-Read packets from the socket
-Parse all buffered DNS responses
-Apply connection error handling afterward if needed

This guarantees that buffered data is always processed before teardown

Signed-off-by: @metsw24-max

45 of 52 new or added lines in 4 files covered. (86.54%)

22908 of 24978 relevant lines covered (91.71%)

12889.43 hits per line