c-ares / c-ares / 24313351165

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix zero-length RAW_RR losing type metadata during parsing (#1129)

ares_dns_parse_rr_raw_rr() returned early when rdlength==0 without
setting ARES_RR_RAW_RR_TYPE, so the record's type was lost (left as 0).
Move the type assignment to the top of the function so it is set
unconditionally, before the zero-length early return.

Add test with a hand-crafted DNS packet containing a zero-length RAW_RR
with type 65432, verifying the type survives the parse.

---------

Signed-off-by: David Hotham (@dimbleby)

Coverage Stats

14 of 15 new or added lines in 2 files covered. (93.33%)

6 existing lines in 2 files now uncovered.

22808 of 24876 relevant lines covered (91.69%)

13052.9 hits per line