tarantool / go-config / 26364311416

87%

master: 87%

Build Type

Pull #76

github

Committed by bigbes

Commit Message

config: keep arrays opaque under default deep-merge

deepMergeNodes (inheritance scope chain) and mergeTreeInto (cross-loader
accumulator) decided whether to recurse with !IsLeaf(). Arrays are also
non-leaf — their indexed children "0", "1", ... look like map keys —
so a higher-priority [a, b] merged into a lower-priority [x, y, z]
ended up as [a, b, z] instead of replacing wholesale.

Surfaced once the previous commit made MergeDeep the default scope-chain
strategy: a Tarantool instance overriding global iproto/listen now leaked
extra global listen entries into the effective view.

- Gate both recursion sites on isMapNode (already !IsLeaf && !IsArray)
  so arrays fall through to the existing "source wins" replace branch.
- Add TestWithInheritance_CrossScope_NestedArrayWholesaleReplace pinning
  the invariant for an iproto/listen override nested in a deep-merged
  iproto parent.

Pull Request Pull Request #76: config: deep-merge maps by default during scope-chain inheritance

Coverage Stats

35 of 35 new or added lines in 3 files covered. (100.0%)

9 existing lines in 1 file now uncovered.

3824 of 4408 relevant lines covered (86.75%)

98.27 hits per line