tarantool / go-config / 26288686435

87%

Build Type

push

github

Committed by bigbes

Commit Message

marshal: quote YAML 1.1 ambiguous string tokens on re-emit

The style-preserving marshal path re-emitted scalars with their original
style. go.yaml.in/yaml/v3 parses unquoted off/on/yes/no as plain !!str under
the YAML 1.2 core schema, so a source token like `failover: off` was
re-emitted unquoted. YAML 1.1 loaders (notably Tarantool's libyaml-based
config reader) interpret the bare token as a boolean, silently changing the
value's meaning on round-trip.

Add forcePlainStringQuoting, applied to preserved scalar nodes: for a plain
string scalar it probe-encodes the value and adopts the quoting yaml/v3 would
choose itself, leaving genuine plain strings and non-string scalars untouched.
The mutated/Set path already quoted such values, so only the preserved path
needed the fix.

Coverage Stats

13 of 15 new or added lines in 1 file covered. (86.67%)

34 existing lines in 1 file now uncovered.

3828 of 4403 relevant lines covered (86.94%)

90.19 hits per line