rust-bitcoin / rust-bitcoin / 26363150826

81%

master: 83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#6182: Manually revert VarInt range check

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3bcd7c99232c0cd2dc942ecb88e9bec0ba06a4ee">3bcd7c992<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/67b9fbb2a5c50112c1fb29ec57302d8ac06f6a05"> Manually revert VarInt range check (Tobin C. Harding)

Pull request description:

  Manually revert <a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/91a6e640ad8f37b697669f9e993106afeab23fd7">91a6e640a</a>
  
  Note that we cannot break the API so the new stuff introduced in `0.32.9` has to stay in there. Comment the code as such.
  
  This was a backport of #5697 which added range checking to the `VarInt` type. On master we did this then realized there are legitimate use cases for the full range of a `u64`. We then added `u64` support to compact size (#5784).
  
  NB: 'compact size' is the new name for varint.
  
  This backport then broke downstream users.
  
  Close: #6138


ACKs for top commit:
  apoelstra:
    ACK 3bcd7c99232c0cd2dc942ecb88e9bec0ba06a4ee; successfully ran local tests


Tree-SHA512: d01078f4f757ebfbcabd36163f29daf116b

Coverage Stats

3 of 4 new or added lines in 2 files covered. (75.0%)

7 existing lines in 1 file now uncovered.

16559 of 20202 relevant lines covered (81.97%)

17495.5 hits per line