rust-bitcoin / rust-bitcoin / 26310969658

81%

master: 83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#6200: Delete `internals` crate

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5f9f46d22265ff0a852c5e2e063ac071220612c4">5f9f46d22<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8a7f848f8776b45eda05afcf1443c4a5f93cd7d5"> Delete the internals crate (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e7d27221109c7e1891f7167b29414ee181df09ca">e7d272211</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8a7f848f8776b45eda05afcf1443c4a5f93cd7d5"> Fix gitignore to ignore all target dirs (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b660b65b5dda182525e21033a6db9031dc646f0d">b660b65b5</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8a7f848f8776b45eda05afcf1443c4a5f93cd7d5"> Move const_tools and ArrayVec to bitcoin (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/72a3ab3d3b9dce3e72193d92d2e05c7ca8565f1b">72a3ab3d3</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8a7f848f8776b45eda05afcf1443c4a5f93cd7d5"> internals: Remove unused parse and serde modules (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3466631087f0cc9b1ffb6c5e109b91c95c700cca">346663108</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8a7f848f8776b45eda05afcf1443c4a5f93cd7d5"> Remove internals::macros (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1b144b3a01bdecc8b5dde1b4fb50019773291b63">1b144b3a0</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8a7f848f8776b45eda05afcf1443c4a5f93cd7d5"> delete unused const_assert macro (Tobin C. Harding)
c372d561a Inline InputString into units crate (Tobin C. Harding)
9870a79fb Remove impl_from_infallible macro (Tobin C. Harding)
26fcc50fa base58: Remove internals dependency (Tobin C. Harding)
ba0ca43f4 Duplicate the write_err macro (Tobin C. Harding)

Pull request description:

  The split between `0.32.10` and `0.32.100` makes `internals` problematic. Lets just duplicate `write_err`, move what is used in one place to where its moved, and delete the `internals` crate from this branch all together.
  
  If this goes in we will need a re-release of `units` before we can to do the `0.32.10` release.


ACKs for top commit:
  apoelstra:
    ACK 5f9f46d22265ff0a852c5e2e063ac071220612c4; successfully ran local tests


Tree-SHA512: 358457a3d942a4e3afd101addf4399f2df0

Coverage Stats

11 of 30 new or added lines in 1 file covered. (36.67%)

17 existing lines in 2 files now uncovered.

16570 of 20215 relevant lines covered (81.97%)

17575.5 hits per line