nats-io / nats-server / 26353494176
76%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 64
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.129% (+2.0%) from 81.166%
26353494176

push

github

web-flow 
Enforce cardinality threshold on `checkSkipFirstBlock` and `checkSkipFirstBlockMulti` (#8227)

At a certain threshold, intersecting the entire stream subject state
becomes considerably more expensive than just walking forward normally,
so we should avoid doing that. In other places in the filestore, we
tweak operations at 1 million subjects, and that seems to roughly align
here too.

Before:
```
goos: darwin
goarch: arm64
pkg: github.com/nats-io/nats-server/v2/server
cpu: Apple M2 Ultra
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1000-24         	    6747	    173332 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/10000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/10000-24        	     735	   1651734 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/100000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/100000-24       	     144	   8261559 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/500000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/500000-24       	      27	  42628478 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1000000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1000000-24      	      13	  87825721 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1500000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1500000-24      	       8	 135479005 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/2000000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/2000000-24      	       6	 184404188 ns/op
PASS
ok  	github.com/nats-io/nats-server/v2/server	206.401s
```

After:
```
goos: darwin
goarch: arm64
pkg: ... (continued)

77680 of 93445 relevant lines covered (83.13%)

458486.2 hits per line

Coverage Regressions

Lines Coverage ∆ File
1629
78.52
 0.16% src/github.com/nats-io/nats-server/server/filestore.go
60
82.16
 -0.26% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
43
82.05
 0.94% src/github.com/nats-io/nats-server/server/raft.go
25
82.05
 -0.53% src/github.com/nats-io/nats-server/server/memstore.go
12
87.95
 0.06% src/github.com/nats-io/nats-server/server/consumer.go
7
56.5
 -0.43% src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
6
78.95
 14.02% src/github.com/nats-io/nats-server/server/opts.go
4
84.74
 0.05% src/github.com/nats-io/nats-server/server/jetstream.go
2
75.26
 0.26% src/github.com/nats-io/nats-server/server/jetstream_api.go
1
87.54
 0.03% src/github.com/nats-io/nats-server/server/monitor.go
1
88.52
 -0.41% src/github.com/nats-io/nats-server/server/util.go
Jobs
ID Job ID Ran Files Coverage
1 26353494176.1 64
83.13
 GitHub Action Run
Source Files on build 26353494176