KarpelesLab / goro / 26350972671

12%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: native foreach over non-by-ref non-local targets

Previously `foreach ($arr as [$a,$b])` / `as $obj->prop` / `as
Foo::$bar` / `as $k => [$a,$b]` etc. were AST-delegated via
OP_TRY_FINALLY, forcing the enclosing function out of slot-only mode
and re-running the whole loop through the AST tree walker.

Adds two opcodes:

  OP_FOREACH_STEP_PUSH (A=keyFlag, C=exhaust-jmp): like OP_FOREACH_STEP
  but pushes value (and key when A=1) onto the stack instead of storing
  into a local slot. Always Dup()s to match the AST runner's snapshot.

  OP_ASSIGN_WRITABLE (A=lhs-ast-idx): pops a value and writes it to the
  AST node at SubASTs[A] via the phpv.Writable interface — handles obj
  prop, array element, static prop, dynamic-name var, etc.

emitForeach now picks per-target shape:
- Both targets bare locals → OP_FOREACH_STEP (unchanged fast path).
- Destructure target → push value, OP_DESTRUCTURE_ASSIGN + refresh slots.
- Other Writable target → push value, OP_ASSIGN_WRITABLE + refresh slots.

By-ref (`as &$v`) still AST-delegates — the iterator needs to yield
refs, which OpForeachInit doesn't build yet. That's the next sub-step.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

73 of 94 new or added lines in 2 files covered. (77.66%)

19 existing lines in 1 file now uncovered.

14654 of 117903 relevant lines covered (12.43%)

2584.35 hits per line