KarpelesLab / goro / 26350835409

12%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: per-handler pending + chain-on-escape for try-finally (bug65784)

The previous global "pending" register clobbered an outer finally's
pending throw when an inner try-catch nested inside that finally caught
an unrelated throw. Each TryHandler now has its own pendingControl slot
in Frame.handlerPending, indexed by handler position — so the inner
dispatch cannot disturb the outer's entry.

Also extends dispatchTryHandler to chain previously-pending throws as
$previous when a new throw escapes a finally body, matching the AST
runner's runnableTry.Run behavior. The abandon-and-chain runs at the
bottom of the dispatch loop, after we've established no handler caught
the throw, so a throw that IS caught by an inner try inside the finally
does not abandon the outer's pending.

Per-handler pending lookup keys off OpFinallyEnd's A field (the handler
index), so the runtime can recover the right finally's parked action
without a separate stack.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

33 of 56 new or added lines in 5 files covered. (58.93%)

2 existing lines in 2 files now uncovered.

14616 of 117826 relevant lines covered (12.4%)

2585.98 hits per line