tarantool / go-tarantool / 26332951575

75%

master: 76%

Build Type

Pull #584

github

Committed by bigbes

Commit Message

request: switch all request types to value receivers and value returns

All New*Request() constructors now return values instead of pointers. All
methods on request types use value receivers and return values, enabling
immutable builder-style chaining.

Renamed all value constructors from Make* to New* for naming consistency
across the connector: crud.Make*Request → crud.New*Request,
datetime.MakeDatetime → datetime.NewDatetime, decimal.MakeDecimal /
MakeDecimalFromString / MustMakeDecimal → decimal.NewDecimal /
NewDecimalFromString / MustNewDecimal, arrow.MakeArrow → arrow.NewArrow,
crud.MakeResult → crud.NewResult.

Removed intermediate spaceRequest, spaceIndexRequest types from the
tarantool package and spaceRequest from the crud package — space and
index fields are inlined directly into each request struct.

Converted all constructors to composite literal style.

Applied the same pattern to arrow/ and settings/ packages.

In the box/ subpackage, request types no longer embed
tarantool.CallRequest. They store it as a private field via
baseCallRequest and implement their own Context() method returning the
wrapper type.

Part of #238

Pull Request Pull Request #584: request: switch all request types to value receivers and value returns

Coverage Stats

183 of 183 new or added lines in 5 files covered. (100.0%)

7 existing lines in 1 file now uncovered.

3107 of 4127 relevant lines covered (75.28%)

9970.65 hits per line