ruby-grape / grape / 26331525912

97%

master: 97%

Build Type

Pull #2737

github

Committed by ericproulx

Commit Message

Make rescue_from reject meta selectors mixed with exception classes

Previously the `*args` signature meant that:

  rescue_from :all, MyError, with: :handler

silently dropped `MyError`: the `if args.include?(:all)` branch fired
and the trailing argument was never registered. Same for
`:grape_exceptions` and `:internal_grape_exceptions`.

Split the signature into a dedicated `first` positional plus `*rest`,
case-dispatch on `first`, and raise `ArgumentError` when a meta
selector is combined with additional positional arguments. Valid
forms (`rescue_from :all`, `rescue_from :all, with:`,
`rescue_from MyError, OtherError, with:`) are unaffected.

CHANGELOG + UPGRADING entries added; three new request_response_spec
examples cover the new ArgumentError contract.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2737: Make rescue_from reject meta selectors mixed with exception classes

Coverage Stats

1088 of 1173 branches covered (92.75%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

3535 of 3594 relevant lines covered (98.36%)

31626.03 hits per line