kobotoolbox / kpi / 26331354639

57%

master: 76%

push

github

feat(frontend): create a reflux to react-query (orval) bridge DEV-2107 (#7040)

### 💭 Notes

Adds a bridge between new react-query code and old Reflux code by
ensuring Reflux listeners are still notified when new code performs API
calls. This lets us migrate incrementally without breaking UI behavior
during the transition.

For example, if a migrated flow previously depended on
removeAssetPermission.completed, we have two options:
1. Migrate only that flow and let the bridge notify legacy listeners.
2. Migrate that flow plus every dependent Reflux listener path
immediately, which can force deeper migration work than planned.

Changes here:
1. `orval.mutator.ts` calls bridge dispatchers at three lifecycle
points, so compatibility stays centralized.
2. `index.ts` remains the dispatch entrypoint and has a clear top-level
explanation of bridge behavior.
3. `shared.ts` contains shared parsing and normalization helpers plus
endpoint pre-match logic.
4. Endpoint handler matching:
1. Handlers configs use endpoint as the source of truth for method and
path shape.
2. Separate method fields were removed from handler tables to reduce
drift.
3. `doesEndpointMatchRequest` is used as a pre-check before
handler-specific matches predicates.
4. `refluxAction` is kept as a diagnostic label (not a matcher), so logs
remain easy to read and trace.
   5. `start-handlers.ts` keeps request-time started callbacks.
6. `success-handlers.ts` handles success callbacks, including split
PATCH deployment behavior for redeploy vs set-active.
7. `failure-handlers.ts` mirrors the same endpoint family for failed
callbacks.
8. `bridge-handlers.tests.ts` includes handler-flow coverage plus
endpoint matcher tests.
5. `jsapp/js/library/managedCollectionsStore.ts`,
`jsapp/js/library/myLibraryStore.ts`,
`jsapp/js/library/publicCollectionsStore.ts`, and
`jsapp/js/library/singleCollectionStore.ts` remove dependence on
`assetType` in delete completion handlers to simplify their code, and
make lif... (continued)

9237 of 12470 branches covered (74.07%)

30550 of 37241 relevant lines covered (82.03%)

5.73 hits per line