DrRataplan / xq-lsp / 26325433729

93%

push

github

fix: don't flag node→atomic as XPTY0004 in function call args (atomization applies)

XQuery function conversion rules (§3.1.5) automatically atomize node arguments
when the expected parameter type is atomic. Our type checker was incorrectly
treating this as a static XPTY0004 error, producing false positives for any
call like tokenize($attr, ' ') or resolve-uri(., $base) where the first
argument is a path expression.

Skip the node→atomic assignability check in typeCheckCall; the pure
isAssignable function is left unchanged for other uses. This removes ~1200
false-positive lines from 39 qt4 test snapshots including all Catalog003/004/
006/010/011/013/014 cases.

645 of 784 branches covered (82.27%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

2307 of 2388 relevant lines covered (96.61%)

582361.89 hits per line